westonpace commented on a change in pull request #10729:
URL: https://github.com/apache/arrow/pull/10729#discussion_r677950980



##########
File path: cpp/src/parquet/column_writer.cc
##########
@@ -1490,7 +1490,8 @@ Status TypedColumnWriterImpl<DType>::WriteArrowDictionary(
     // TODO(wesm): If some dictionary values are unobserved, then the

Review comment:
       Sorry for taking so long to get back to this but I dug into this a bit 
today and I can't find any page statistics.  Either in the code or the thrift 
definition.  Can you give me a pointer to the statistics objects you think 
might be incorrect.
   
   There is a `PageEncodingStats` which has a `count` but that appears to be 
counting the number of pages and not counting the rows.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to