waynexia commented on a change in pull request #792:
URL: https://github.com/apache/arrow-datafusion/pull/792#discussion_r682541497



##########
File path: datafusion/src/logical_plan/expr.rs
##########
@@ -914,7 +916,7 @@ impl Expr {
                 negated,
             } => Expr::InList {
                 expr: rewrite_boxed(expr, rewriter)?,
-                list,
+                list: rewrite_vec(list, rewriter)?,

Review comment:
       I think this is an accident.
   
   Since this PR now contains two changes about "expr" (this one and 
`RewriteRecursion` below), perhaps it would be clearer to move these changes to 
another PR?
   
   cc @alamb 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to