lidavidm commented on a change in pull request #10890:
URL: https://github.com/apache/arrow/pull/10890#discussion_r685624528
##########
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##########
@@ -133,6 +134,116 @@ Result<std::unique_ptr<KernelState>>
MeanInit(KernelContext* ctx,
return visitor.Create();
}
+// ----------------------------------------------------------------------
+// Product implementation
+
+using arrow::internal::MultiplyWithOverflow;
+
+template <typename ArrowType>
+struct ProductImpl : public ScalarAggregator {
+ using ThisType = ProductImpl<ArrowType>;
+ using CType = typename ArrowType::c_type;
+ using ProductType = typename FindAccumulatorType<ArrowType>::Type;
+ using OutputType = typename TypeTraits<ProductType>::ScalarType;
+
+ explicit ProductImpl(const ScalarAggregateOptions& options) { this->options
= options; }
+
+ Status Consume(KernelContext*, const ExecBatch& batch) override {
+ if (batch[0].is_array()) {
+ const auto& data = batch[0].array();
+ this->count += data->length - data->GetNullCount();
+ return VisitArrayDataInline<ArrowType>(
+ *data,
+ [&](typename TypeTraits<ArrowType>::CType value) {
+ if (ARROW_PREDICT_FALSE(
+ MultiplyWithOverflow(this->product, value,
&this->product))) {
+ return Status::Invalid("Overflow in product");
+ }
+ return Status::OK();
+ },
+ [] { return Status::OK(); });
+ } else {
+ const auto& data = *batch[0].scalar();
+ this->count += data.is_valid * batch.length;
Review comment:
There was a test in plan_test.cc that's now extended, though not all the
aggregate kernels actually work in a plan (index: ARROW-13591, mode/quantile:
not truly aggregate kernels)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
