pitrou commented on a change in pull request #10907:
URL: https://github.com/apache/arrow/pull/10907#discussion_r687082488
##########
File path: cpp/src/arrow/compute/exec/key_hash.cc
##########
@@ -186,11 +186,12 @@ void Hashing::hash_varlen_helper(uint32_t length, const
uint8_t* key, uint32_t*
int tail = length % 16;
if (tail) {
- uint64_t last_stripe[2];
- const uint64_t* last_stripe_base =
+ uint32_t lanes[4];
+ uint64_t* const last_stripe = reinterpret_cast<uint64_t*>(lanes);
Review comment:
Well... More radical, though, is to question the existence of this
function. We have another string hash function here:
https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/hashing.h#L130
Perhaps try to use it and see if performance differs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
