michalursa commented on a change in pull request #10290:
URL: https://github.com/apache/arrow/pull/10290#discussion_r688217220
##########
File path: cpp/src/arrow/compute/kernels/hash_aggregate_test.cc
##########
@@ -991,6 +991,9 @@ TEST(GroupBy, SumOnlyStringAndDictKeys) {
{
{"hash_sum", nullptr},
}));
+ if (key_type->Equals(utf8())) {
Review comment:
SortBy doesn't work for string dictionary type. And accidentally the
order does not change for this test case, so it works across the systems. If
you can tell me how to sort dictionary array I will change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
