houqp commented on a change in pull request #811:
URL: https://github.com/apache/arrow-datafusion/pull/811#discussion_r688299568



##########
File path: ballista/rust/core/src/utils.rs
##########
@@ -252,6 +252,11 @@ pub fn create_datafusion_context(
     ExecutionContext::with_config(config)
 }
 
+/// Create a DataFusion context that is compatible with Ballista in concurrency
+pub fn create_datafusion_context_concurrency(concurrency: usize) -> 
ExecutionContext {

Review comment:
       Nitpick, I think `ExecutionContext::with_concurrency(24)` is as readable 
as `create_datafusion_context_concurrency(24)` but incurs less 
indirection/abstraction, so IMHO this helper function doesn't provide a lot of 
value.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to