nealrichardson commented on a change in pull request #10710:
URL: https://github.com/apache/arrow/pull/10710#discussion_r689518479
##########
File path: dev/tasks/docker-tests/github.linux.yml
##########
@@ -41,10 +41,11 @@ jobs:
shell: bash
run: archery docker run -e SETUPTOOLS_SCM_PRETEND_VERSION="{{
arrow.no_rc_version }}" {{ flags|default("") }} {{ image }} {{
command|default("") }}
- {% if '-r-' in image %}
+ {% if '-r' in image %}
Review comment:
Why this change? Is this too broad?
##########
File path: dev/tasks/r/azure.linux.yml
##########
@@ -50,6 +50,7 @@ jobs:
export ARROW_R_DEV={{ not_cran|default("TRUE") }}
# Note that ci/scripts/r_test.sh sets NOT_CRAN=true if
ARROW_R_DEV=TRUE
docker-compose run \
+ {{ flags|default("") }} \
Review comment:
I think this change is also on master now so this probably means you
need to rebase
##########
File path: ci/docker/linux-apt-r.dockerfile
##########
@@ -100,7 +100,7 @@ ENV \
ARROW_BUILD_STATIC=OFF \
ARROW_BUILD_TESTS=OFF \
ARROW_BUILD_UTILITIES=OFF \
- ARROW_DEPENDENCY_SOURCE=SYSTEM \
+ ARROW_DEPENDENCY_SOURCE="" \
Review comment:
Why this change? This build should not be affected by the scope of the
changes in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
