rok commented on a change in pull request #10457:
URL: https://github.com/apache/arrow/pull/10457#discussion_r690413546
##########
File path: r/tests/testthat/test-dplyr-lubridate.R
##########
@@ -26,22 +26,13 @@ library(dplyr)
# TODO: consider reevaluating this workaround after ARROW-12980
withr::local_timezone("UTC")
-test_date <- as.POSIXct("2017-01-01 00:00:12.3456789", tz = "")
+if (tolower(Sys.info()[["sysname"]]) == "windows") {
Review comment:
Without `-lole32` flag all zoned time logic was causing errors at
compile time (if I remember correctly) so it would have to be disabled for
windows. Since we will eventually have zones on windows I went ahead and rather
added the flag.
Here's a [similar issue from
date.h](https://github.com/HowardHinnant/date/issues/272) and a similar
[discussion from another
PR](https://github.com/apache/arrow/pull/10610#pullrequestreview-705668997).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
