lidavidm commented on a change in pull request #10906:
URL: https://github.com/apache/arrow/pull/10906#discussion_r695117858
##########
File path: format/FlightSql.proto
##########
@@ -0,0 +1,454 @@
+/*
Review comment:
I would be a little worried about supporting LTS releases of Ubuntu and
such. It does seem to be in conda-forge already, at least.
And we already vary our Protobuf version based on features requested:
https://github.com/apache/arrow/blob/04575bc8e90216d8e685d1b857f487708426001c/cpp/cmake_modules/ThirdpartyToolchain.cmake#L1415-L1424
so I suppose this wouldn't change the situation there (20.04 LTS ships
Protobuf 3.6 anyways).
We may also have to bump Protobuf if/when we upgrade gRPC, though, I cannot
figure out what exactly gRPC requires even after some searching. It seems v1.38
uses Protobuf 3.15 though it is not clear if that is a hard floor or not.
@kszucs how much trouble would it be to bump our Protobuf version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
