Igosuki commented on a change in pull request #910:
URL: https://github.com/apache/arrow-datafusion/pull/910#discussion_r696528746
##########
File path: datafusion/src/physical_plan/expressions/nth_value.rs
##########
@@ -78,7 +78,7 @@ impl NthValue {
}
/// Create a new NTH_VALUE window aggregate function
- pub fn nth_value(
+ pub fn value(
Review comment:
It breaks on the latest nightly with new clippy rules, specifically the
one where they don't want a method to have the same name as the Struct or
Trait, I tried to exclude the clippy rule but it doesn't work on stable because
it doesn't exist, and there are no conditional attributes for nightly/stable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
