jonkeane commented on a change in pull request #10888:
URL: https://github.com/apache/arrow/pull/10888#discussion_r697480591
##########
File path: r/R/dataset-scan.R
##########
@@ -85,9 +85,26 @@ Scanner$create <- function(dataset,
# To handle mutate() on Table/RecordBatch, we need to
collect(as_data_frame=FALSE) now
dataset <- dplyr::collect(dataset, as_data_frame = FALSE)
}
+
+ proj <- c(dataset$selected_columns, dataset$temp_columns)
+ if (!is.null(projection)) {
+ # grab all of the projection elements that are characters to select
columns
+ # TODO: should we check names and make sure we only project once per?
Review comment:
This was (partially) a holdover from the code that Hannes proposed — I
also though there was another constraint about fields named the same. I tried
projections with multiple of the same columns and it works just fine (even if
it is a little bit of an odd thing to do), so I'll delete this since it works
if someone wants to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
