alamb commented on a change in pull request #714:
URL: https://github.com/apache/arrow-rs/pull/714#discussion_r697663939
##########
File path: arrow/src/alloc/types.rs
##########
@@ -36,7 +36,7 @@ pub unsafe trait NativeType:
}
macro_rules! create_native {
- ($native_ty:ty,$($impl_pattern:pat)|+) => {
+ ($native_ty:ty,$($impl_pattern:pat_param)|+) => {
Review comment:
@jhorstmann -- I backported this change to the proposed arrow 5.3.0.
Given your experience, I think I should probably undo that change and make a
new 5.3.0 RC candidate.
@Jimexist / @jhorstmann any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
