yjshen commented on a change in pull request #932:
URL: https://github.com/apache/arrow-datafusion/pull/932#discussion_r697951379
##########
File path: ballista/rust/scheduler/src/lib.rs
##########
@@ -282,24 +282,18 @@ impl SchedulerGrpc for SchedulerServer {
match file_type {
FileType::Parquet => {
- let parquet_exec =
- ParquetExec::try_from_path(&path, None, None, 1024, 1,
None)
- .map_err(|e| {
- let msg = format!("Error opening parquet files:
{}", e);
- error!("{}", msg);
- tonic::Status::internal(msg)
- })?;
+ let parquet_desc =
ParquetTableDescriptor::new(&path).map_err(|e| {
+ let msg = format!("Error opening parquet files: {}", e);
+ error!("{}", msg);
+ tonic::Status::internal(msg)
+ })?;
//TODO include statistics and any other info needed to
reconstruct ParquetExec
Ok(Response::new(GetFileMetadataResult {
- schema: Some(parquet_exec.schema().as_ref().into()),
- partitions: parquet_exec
- .partitions()
- .iter()
- .map(|part| FilePartitionMetadata {
- filename: part.filenames().to_vec(),
- })
- .collect(),
+ schema: Some(parquet_desc.schema().as_ref().into()),
+ partitions: vec![FilePartitionMetadata {
+ filename: vec![path],
Review comment:
I changed it to a vector of all the files.
However, after searching for a while in the project, I find this method may
not be actually used, it's hard to understand this RPC's intention as well.
Perhaps it's deprecated and we should remove it later?
```
rpc GetFileMetadata (GetFileMetadataParams) returns (GetFileMetadataResult)
{}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
