westonpace commented on a change in pull request #10913:
URL: https://github.com/apache/arrow/pull/10913#discussion_r698961560



##########
File path: cpp/src/arrow/dataset/scanner_internal.h
##########
@@ -185,6 +185,10 @@ inline Result<ScanTaskIterator> GetScanTaskIterator(
   auto fn = [options](std::shared_ptr<Fragment> fragment) -> 
Result<ScanTaskIterator> {
     ARROW_ASSIGN_OR_RAISE(auto scan_task_it, fragment->Scan(options));
 
+    if (options->skip_compute) {

Review comment:
       I looked at this today and it's not as straightforward a port as I 
thought.  The exec plan drops the fragment information for the most part.  I'll 
try and take a more comprehensive stab at this later.  Worst case I don't think 
it will break things if we filter & project twice and the ExecPlan may not be 
where we want to do this kind of optimization.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to