jorgecarleitao edited a comment on pull request #11071: URL: https://github.com/apache/arrow/pull/11071#issuecomment-911948221
Can't review the c++ in depth, but from what I can read, I took an equivalent approach (https://github.com/jorgecarleitao/arrow2/pull/363), which I am glad of. To import 1. read metadata 2. detect extension from meta 3. use extension To export 1. create meta map with extension name and meta 2. fill meta map with remaining meta from field 3. unwrap inner from extension 4. expose in c data interface There is a small divergence in that we remove the extension fields from the field's metadata when consuming from IPC and FFI, and automatically convert them to the `DataType::Extension` variant (and vice-versa on export). AFAI understand this is an implementation detail that does not impact how they communicate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
