zhztheplayer commented on pull request #10883: URL: https://github.com/apache/arrow/pull/10883#issuecomment-913739135
@kiszk I have added a mock test against batch exporting (unsafe serialization) code from C++ side. https://github.com/apache/arrow/pull/10883/commits/c004e818091242148861a759755e339e648c71ed Unsafe importing part will be even tricky so I didn't add test case for that. The function `arrow::dataset::jni::DeserializeUnsafeFromJava` require for a byte array that was serialized out from Java side utility method. So we will end up adding magic byte inputs if we want to unit test this part of code in C++. Do you have any thoughts around this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
