edponce commented on pull request #11113: URL: https://github.com/apache/arrow/pull/11113#issuecomment-915821085
After revisiting the `sign` compute function, I noticed that kernels are registered with `Int8Type` for integral types and corresponding floating-point for floating-point types. The kernels' `Call` methods are stated to be enabled if they return unsigned int, signed int, and floating-point. The unsigned int kernel is therefore never invoked. To fix this, the `enable_if` checks should be done against `Arg0` or `Arg1`. Also, shouldn't the floating-point kernels also return the same int type for `sign` function? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
