roee88 commented on a change in pull request #11067: URL: https://github.com/apache/arrow/pull/11067#discussion_r707166045
########## File path: java/ffi/README.md ########## @@ -0,0 +1,48 @@ +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Java FFI (C Data Interface) + +## Setup Build Environment + +install: + - Java 8 or later + - Maven 3.3 or later + - A C++11-enabled compiler + - CMake 3.11 or later + - Make or ninja build utilities + +## Building JNI wrapper shared library + +``` +mkdir -p ./target/build/ +pushd ./target/build/ +cmake ../.. +make +popd +``` Review comment: > This is entirely independent from Arrow C++, so it should live in the Arrow Java source tree. @pitrou I believe this adds a lot of complexity that is already solved in the cpp side of the project (cross-platform builds, linting, packaging, etc.). I would like to propose adopting the suggestion by @zhztheplayer to move it to cpp/jni. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
