aocsa commented on pull request #11164: URL: https://github.com/apache/arrow/pull/11164#issuecomment-920920214
> I am personally fine with the "top_k" / "bottom_k" specializations of "select_k" (it makes it more convenient to use), but I am wondering whether, if we want those, we shouldn't rather add them in C++? Because now those kernels are python specific, and eg also won't work in a query execution context. In previous review at https://github.com/apache/arrow/pull/11019, there was a common agreement to expose just one general API. However we can add these specialization in a follow-up PR which implements ` SelectKStable` https://issues.apache.org/jira/browse/ARROW-13969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
