Dandandan commented on a change in pull request #1018:
URL: https://github.com/apache/arrow-datafusion/pull/1018#discussion_r711151904
##########
File path: datafusion/src/physical_plan/union.rs
##########
@@ -82,11 +92,18 @@ impl ExecutionPlan for UnionExec {
}
async fn execute(&self, mut partition: usize) ->
Result<SendableRecordBatchStream> {
+ let baseline_metrics = BaselineMetrics::new(&self.metrics, partition);
+ // record the tiny amount of work done in this function so
+ // elapsed_compute is reported as non zero
+ let timer = baseline_metrics.elapsed_compute().timer();
+
// find partition to execute
for input in self.inputs.iter() {
// Calculate whether partition belongs to the current partition
if partition < input.output_partitioning().partition_count() {
- return input.execute(partition).await;
+ let stream = input.execute(partition).await?;
+ drop(timer);
Review comment:
Is this drop needed if the next line contains a `return`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
