lidavidm commented on pull request #10913: URL: https://github.com/apache/arrow/pull/10913#issuecomment-923408261
> > I realize CheckClosed is private, but what about ReadAt, etc.? > > @lidavidm `CheckClosed` is public right ? Ah yes, but it's not in the interface of RandomAccessFile. However, the overall point still stands; please declare `override` where appropriate. (CheckClosed doesn't need it, other methods do.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
