jonkeane commented on a change in pull request #11225:
URL: https://github.com/apache/arrow/pull/11225#discussion_r717030936
##########
File path: r/tests/testthat/test-altrep.R
##########
@@ -193,15 +195,33 @@ test_that("altrep min/max/sum identical to R versions for
int", {
test_that("altrep vectors handle serialization", {
ints <- c(1L, 2L, NA_integer_)
dbls <- c(1, 2, NA_real_)
+ strs <- c("un", "deux" , NA_character_)
expect_identical(ints, unserialize(serialize(Array$create(ints)$as_vector(),
NULL)))
expect_identical(dbls, unserialize(serialize(Array$create(dbls)$as_vector(),
NULL)))
+ expect_identical(strs, unserialize(serialize(Array$create(strs)$as_vector(),
NULL)))
+ expect_identical(strs, unserialize(serialize(Array$create(strs,
large_utf8())$as_vector(), NULL)))
})
test_that("altrep vectors handle coercion", {
ints <- c(1L, 2L, NA_integer_)
dbls <- c(1, 2, NA_real_)
+ strs <- c("1", "2" , NA_character_)
Review comment:
```suggestion
strs <- c("1", "2", NA_character_)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
