lidavidm commented on a change in pull request #11273:
URL: https://github.com/apache/arrow/pull/11273#discussion_r719344389
##########
File path: cpp/src/arrow/compute/kernels/vector_sort.cc
##########
@@ -2538,6 +2686,10 @@ class TableSelecter : public TypeVisitor {
return q;
}
+ // XXX this implementation is rather inefficient as it computes chunk indices
+ // at every comparison. Instead we should iterate over individual batches
+ // and remember ChunkLocation entries in the max-heap.
Review comment:
Filed ARROW-14183 for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
