alamb edited a comment on pull request #813: URL: https://github.com/apache/arrow-rs/pull/813#issuecomment-934713514
This is a very cool idea @jhorstmann -- thank you. Do you have any thoughts on when it would be most appropriate to apply the two levels of "validate"? * `ArrayData::validate`: "cheap" validation checks that checks that the lengths + offsets into the data buffers are within bounds but does not actually look at any data (e.g. it doesn't look at the actual values of offsets in Utf8 arrays) * `ArrayData::validate_full`: "expensive" validation checks that actually look at the contents of the buffers to ensure data integrity is maintained Specifically, I am wondering if you think `ArrayData::validate` would be ok to be done always (even in `ArrayData::new_unchecked`) or if `new_unchecked` should really skip all validation checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
