nealrichardson commented on pull request #11355:
URL: https://github.com/apache/arrow/pull/11355#issuecomment-938014150


   > Hmmm, like you mentioned, we are doing a bit of post-processing when 
executing `%/%` by [casting to an 
int](https://github.com/apache/arrow/blob/master/r/R/expression.R#L218). You 
should look into the `allow_float_truncate` option. I thought that it would 
allow turning a float to an integer (with `floor()`-like behavior), but it 
might be doing something else. We might replace that with our own `floor` 
binding (or something else) to get this behavior right.
   
   `floor` and other rounding kernels didn't exist when we initially did the 
division bindings, definitely worth considering.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to