kou commented on a change in pull request #11331:
URL: https://github.com/apache/arrow/pull/11331#discussion_r724619541
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -3704,6 +3706,13 @@ endmacro()
if(ARROW_WITH_GOOGLE_CLOUD_CPP)
resolve_dependency(google_cloud_cpp_storage)
+ include_directories(SYSTEM ${GOOGLE_CLOUD_CPP_INCLUDE_DIR})
+ get_target_property(absl_base_INCLUDE_DIR absl::base
INTERFACE_INCLUDE_DIRECTORIES)
+ include_directories(SYSTEM ${absl_base_INCLUDE_DIR})
+ message(STATUS "Found google-cloud-cpp::storage static library:
${GOOGLE_CLOUD_CPP_STATIC_LIBRARY_STORAGE}"
+ )
+ message(STATUS "Found google-cloud-cpp::storage headers:
${GOOGLE_CLOUD_CPP_INCLUDE_DIR}"
+ )
Review comment:
Could you extract include dir and static library path information from
`google-cloud-cpp::storage`?
If we use system Google Cloud Storage
(`find_package(google_cloud_cpp_storage)` is succeeded case),
`GOOGLE_CLOUD_CPP_*` aren't defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
