Jimexist commented on pull request #1077:
URL: https://github.com/apache/arrow-datafusion/pull/1077#issuecomment-939200787


   @alamb in fact `dense_rank` function was already implemented, this PR only 
added percent rank and thus i needed to change the `dense: bool` to a three 
element enum. same goes to unit test, as the code originally covered both rank 
and dense_rank.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to