alamb commented on pull request #822: URL: https://github.com/apache/arrow-rs/pull/822#issuecomment-939370985
> I think we should have some notes around the usages of unsafe: why is it sound in this place? It is a good idea @Dandandan -- I will attempt to do so. To be honest I am not sure why all the references are legitimate uses of `unsafe`. I don't think this PR has made the code any more or less safe / unsafe than it was before. However, it is now clearer where assumptions are made (they are all annotated with `unsafe`). I sort of imagine over time people can chip away at removing the `unsafe` possible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
