alamb commented on a change in pull request #1105:
URL: https://github.com/apache/arrow-datafusion/pull/1105#discussion_r726557849
##########
File path: datafusion/src/physical_plan/sort.rs
##########
@@ -474,4 +487,137 @@ mod tests {
Ok(())
}
+
+ #[tokio::test]
+ async fn test_drop_cancel() -> Result<()> {
+ let schema =
+ Arc::new(Schema::new(vec![Field::new("a", DataType::Float32,
true)]));
+
+ let blocking_exec = Arc::new(BlockingExec::new(Arc::clone(&schema)));
+ let refs = blocking_exec.refs();
+ let sort_exec = Arc::new(SortExec::try_new(
+ vec![PhysicalSortExpr {
+ expr: col("a", &schema)?,
+ options: SortOptions::default(),
+ }],
+ blocking_exec,
+ )?);
+
+ let fut = collect(sort_exec);
+ let mut fut = fut.boxed();
+
+ let waker = futures::task::noop_waker();
+ let mut cx = futures::task::Context::from_waker(&waker);
+ let poll = fut.poll_unpin(&mut cx);
+
+ assert!(poll.is_pending());
+ drop(fut);
+ tokio::time::timeout(std::time::Duration::from_secs(10), async {
+ loop {
+ if dbg!(Weak::strong_count(&refs)) == 0 {
+ break;
+ }
+ tokio::time::sleep(std::time::Duration::from_millis(10)).await;
+ }
+ })
+ .await
+ .unwrap();
+
+ Ok(())
+ }
+
+ #[derive(Debug)]
+ struct BlockingExec {
Review comment:
Some comments here might help -- especally on the `refs: Arc<()>` field
which looks very strange until one reads the test and sees that `refs` is
effectively being used to test when `BlockingExec` is dropped
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
