roee88 commented on a change in pull request #11067:
URL: https://github.com/apache/arrow/pull/11067#discussion_r726781442



##########
File path: ci/scripts/java_build.sh
##########
@@ -84,6 +85,10 @@ if [ "${ARROW_JAVA_SHADE_FLATBUFFERS}" == "ON" ]; then
   ${mvn} -Pshade-flatbuffers install
 fi
 
+if [ "${ARROW_JAVA_FFI}" = "ON" ]; then
+  ${mvn} -Darrow.ffi.cpp.build.dir=${ffi_build_dir} -Parrow-ffi install

Review comment:
       With the previous suggestion about also renaming the package to `c` and 
the class to `Data`, I thought that this property should now be called 
`arrow.c.jni.dist.dir`. (`arrow.c` to be similar to `arrow.vector.*` and 
`arrow.memory.*` properties that start with the package/module name and 
`jni.dist.dir` to indicate that this is the directory with the shared libs). Is 
that OK?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to