kou commented on a change in pull request #11067:
URL: https://github.com/apache/arrow/pull/11067#discussion_r726786408



##########
File path: ci/scripts/java_build.sh
##########
@@ -84,6 +85,10 @@ if [ "${ARROW_JAVA_SHADE_FLATBUFFERS}" == "ON" ]; then
   ${mvn} -Pshade-flatbuffers install
 fi
 
+if [ "${ARROW_JAVA_FFI}" = "ON" ]; then
+  ${mvn} -Darrow.ffi.cpp.build.dir=${ffi_build_dir} -Parrow-ffi install

Review comment:
       Ah, `c` may mislead C GLib implementation.
   Generally, we use "GLib" or "C GLib" for C GLib implementation. Most of 
people will not think about C GLib implementation by `c` here.
   And `c` means Arrow's C data interface here. (It doesn't mean C language is 
used for implementation.) It's natural that we use `c` here.
   So I'm OK with `arrow.c.jni.dist.dir`. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to