jonkeane commented on a change in pull request #11361:
URL: https://github.com/apache/arrow/pull/11361#discussion_r727530573



##########
File path: r/R/metadata.R
##########
@@ -142,6 +142,21 @@ arrow_attributes <- function(x, only_top_level = FALSE) {
   }
 
   columns <- NULL
+
+  # Check if there are any columns that look like sf columns, warn that we will
+  # not be saving this data for now (but only if 
arrow.preserve_row_level_metadata
+  # is set to FALSE)
+  possible_sf_col <- inherits(x, c("sfc", "sf"))
+  if (!getOption("arrow.preserve_row_level_metadata", FALSE) && 
possible_sf_col) {
+    warning(
+      "One of the columns given appears to be an `sfc` SF column. Due to their 
unique ",
+      "nature, these columns do not convert to Arrow well. We are working on ",
+      "better ways to do this, but in the interim we recommend converting any 
`sfc` ",
+      "columns to WKB (well-known binary) columns before using them with 
Arrow.",

Review comment:
       We could also talk about sfarrow here (or maybe just in the news, since 
it'll be easier to link to?)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to