novemberkilo commented on a change in pull request #832:
URL: https://github.com/apache/arrow-rs/pull/832#discussion_r730710459
##########
File path: arrow/src/csv/reader.rs
##########
@@ -706,8 +706,10 @@ impl Parser for TimestampMicrosecondType {
fn parse(string: &str) -> Option<i64> {
match Self::DATA_TYPE {
DataType::Timestamp(TimeUnit::Microsecond, None) => {
- let date_time = string.parse::<chrono::NaiveDateTime>().ok()?;
- Self::Native::from_i64(date_time.timestamp_nanos() / 1000)
+ let nanos = string_to_timestamp_nanos(string).ok();
+ nanos.map(|x| x / 1000)
+ // let date_time =
string.parse::<chrono::NaiveDateTime>().ok()?;
Review comment:
Ah oops - done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
