edponce commented on pull request #11023: URL: https://github.com/apache/arrow/pull/11023#issuecomment-947079157
I have the following questions which I am not sure how to resolve: 1. I tried allowing integers, floating point, and boolean to the `num_repeats` argument. These are [casted to `Int64Type` via `DispatchBest`](https://github.com/apache/arrow/pull/11023/files#diff-eb8300bc4dea7d1c46b2576b7dbd8e42b927ab7d42c031f4aecae892a72ee244R2925-R2930) but the [floating point casting to integers triggers truncation error](https://github.com/apache/arrow/pull/11023/files#diff-f17bc6ceaa2e16784e3ade31f1cafde21fcd6fa19800c6601dac12e28e7fa79dR798). How can this be achieved? 2. Should an error be return if `num_repeats` argument is non-negative? Currently, a negative value is treated as a zero-value to match Python behavior, but base R `strrep` triggers error. 3. Added [R binding named as `strrep`](https://github.com/apache/arrow/pull/11023/files#diff-43be4da1ac54813d9268544a10ea7cf92b2398ff682fee337bcd2a85db98ddd6R337) but the base R version is used instead cc @jonkeane ```r Warning: Expression strrep(x, 3) not supported in Arrow; pulling data into R ``` cc @lidavidm @bkietz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
