alamb commented on a change in pull request #1163:
URL: https://github.com/apache/arrow-datafusion/pull/1163#discussion_r733984825
##########
File path: datafusion/src/physical_plan/expressions/binary.rs
##########
@@ -814,14 +870,68 @@ pub fn binary(
Ok(Arc::new(BinaryExpr::new(l, op, r)))
}
+// TODO file a ticket with arrow-rs to include these kernels
Review comment:
```suggestion
// When arrow-rs has these kernels, can remove this implementation
// see https://github.com/apache/arrow-rs/issues/842
```
Filed ticket in arrow https://github.com/apache/arrow-rs/issues/842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
