alamb commented on a change in pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#discussion_r734961556
##########
File path: arrow/src/csv/reader.rs
##########
@@ -1341,6 +1341,7 @@ mod tests {
assert_eq!(infer_field_schema("\"123\""), DataType::Utf8);
assert_eq!(infer_field_schema("10"), DataType::Int64);
assert_eq!(infer_field_schema("10.2"), DataType::Float64);
+ assert_eq!(infer_field_schema(".2"), DataType::Float64);
Review comment:
@brianrackle can you please rebase this PR (it should then pass CI) and
let us know if you will be able to add the test that @Jimexist suggests?
I am starting to prepare for the 6.1 release (I plan to build the release
candidate late next week) and would like to get this in if possibkel
##########
File path: arrow/src/csv/reader.rs
##########
@@ -1341,6 +1341,7 @@ mod tests {
assert_eq!(infer_field_schema("\"123\""), DataType::Utf8);
assert_eq!(infer_field_schema("10"), DataType::Int64);
assert_eq!(infer_field_schema("10.2"), DataType::Float64);
+ assert_eq!(infer_field_schema(".2"), DataType::Float64);
Review comment:
@brianrackle can you please rebase this PR (it should then pass CI) and
let us know if you will be able to add the test that @Jimexist suggests?
I am starting to prepare for the 6.1 release (I plan to build the release
candidate late next week) and would like to get this in if possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
