edponce edited a comment on pull request #11023: URL: https://github.com/apache/arrow/pull/11023#issuecomment-953373581
The new changes capture invalid repeat counts early-on (in [`PreExec` when Scalar](https://github.com/apache/arrow/pull/11023/files#diff-eb8300bc4dea7d1c46b2576b7dbd8e42b927ab7d42c031f4aecae892a72ee244R2963-R2967) and in [`MaxCodeunit` when Array](https://github.com/apache/arrow/pull/11023/files#diff-eb8300bc4dea7d1c46b2576b7dbd8e42b927ab7d42c031f4aecae892a72ee244R2888)). Note that to capture these errors and trickle up the error to the `ExecXXX` class/methods [here](https://github.com/apache/arrow/pull/11023/files#diff-eb8300bc4dea7d1c46b2576b7dbd8e42b927ab7d42c031f4aecae892a72ee244R663) and [here](https://github.com/apache/arrow/pull/11023/files#diff-eb8300bc4dea7d1c46b2576b7dbd8e42b927ab7d42c031f4aecae892a72ee244R676), [a `Status` data member was added to `StringBinaryTransformBase`](https://github.com/apache/arrow/pull/11023/files#diff-eb8300bc4dea7d1c46b2576b7dbd8e42b927ab7d42c031f4aecae892a72ee244R604). The alternative would be to add a `Status` parameter to `MaxCodeunit()` and `Transform()`, which now that I think of it, it makes more sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
