kou commented on a change in pull request #11567:
URL: https://github.com/apache/arrow/pull/11567#discussion_r739542852
##########
File path: ci/scripts/python_build.sh
##########
@@ -19,8 +19,10 @@
set -ex
+arrow_dir=${1}
source_dir=${1}/python
Review comment:
```suggestion
source_dir=${arrow_dir}/python
```
##########
File path: ci/scripts/js_build.sh
##########
@@ -20,6 +20,7 @@
set -ex
source_dir=${1}/js
+build_dir=${2}
with_docs=${2:-false}
Review comment:
```suggestion
with_docs=${3:-false}
```
##########
File path: ci/scripts/c_glib_build.sh
##########
@@ -21,7 +21,10 @@ set -ex
source_dir=${1}/c_glib
build_dir=${2}/c_glib
-: ${ARROW_GLIB_GTK_DOC:=false}
+build_root=${2}
+with_docs=${3:-false}
+
+: ${ARROW_GLIB_GTK_DOC:=${with_docs}}
Review comment:
We can remove `ARROW_GLIB_GTK_DOC` and specify `-Dgtk_doc=${with_docs}`
for `meson`.
##########
File path: ci/scripts/r_build.sh
##########
@@ -20,6 +20,7 @@ set -ex
: ${R_BIN:=R}
source_dir=${1}/r
+build_dir=${2}
with_docs=${2:-false}
Review comment:
```suggestion
with_docs=${3:-false}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
