kou commented on a change in pull request #11562:
URL: https://github.com/apache/arrow/pull/11562#discussion_r739928991
##########
File path: dev/release/VERIFY.md
##########
@@ -26,9 +26,9 @@ Windows. Read the comments in `verify-release-candidate.bat`
for instructions.
## Linux and macOS
-We've provided a convenience script for verifying the C++, Python, C
-GLib, Java and JavaScript builds on Linux and macOS. Read the comments in
-`verify-release-candidate.sh` for instructions.
+We've provided a convenience script for verifying the C++, C#, C GLib, Go,
+Java, Javascript, Ruby and Python builds on Linux and macOS. Read the script
Review comment:
```suggestion
Java, JavaScript, Ruby and Python builds on Linux and macOS. Read the script
```
##########
File path: dev/release/setup-AlmaLinux-Rocky-Linux.sh
##########
@@ -0,0 +1,56 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+# A script to install dependencies required for release
+# verification on AlmaLinux 8 and Rocky Linux 8
+
+if [ $# -lt 2 ]; then
+ echo "Usage: $0 VERSION rc"
+ echo " $0 VERSION staging-rc"
+ echo " $0 VERSION release"
+ echo " $0 VERSION staging-release"
+ echo " $0 VERSION local"
+ echo " e.g.: $0 0.13.0 3 # Verify 0.13.0 3"
+ echo " e.g.: $0 0.13.0 staging-rc # Verify 0.13.0 RC on staging"
+ echo " e.g.: $0 0.13.0 release # Verify 0.13.0"
+ echo " e.g.: $0 0.13.0 staging-release # Verify 0.13.0 on staging"
+ echo " e.g.: $0 0.13.0-dev20210203 local # Verify 0.13.0-dev20210203 on
local"
+ exit 1
+fi
+
+VERSION="$1"
+TYPE="$2"
+
+sudo dnf -y update
+sudo dnf clean all
+sudo dnf -y install dnf-plugins-core
+sudo dnf config-manager --set-enabled powertools
+sudo dnf update
+sudo dnf -y install \
+ https://dl.fedoraproject.org/pub/epel/epel-release-latest-8.noarch.rpm
+sudo dnf -y install ninja-build libcurl-devel python3-pip cmake git
+sudo dnf -y ncurses-devel gobject-introspection-devel libffi-devel
+sudo dnf -y install openssl-devel maven java-1.8.0-openjdk-devel
+sudo dnf install -y yum-utils readline-devel gdbm-devel ruby-devel
+sudo dnf -y groupinstall "Development Tools"
+sudo dnf -y module enable llvm-toolset
+sudo dnf -y module install llvm-toolset
Review comment:
Are they needed?
`llvm-toolset` is included in appstream too.
##########
File path: dev/release/setup-AlmaLinux-Rocky-Linux.sh
##########
@@ -0,0 +1,56 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+# A script to install dependencies required for release
+# verification on AlmaLinux 8 and Rocky Linux 8
+
+if [ $# -lt 2 ]; then
+ echo "Usage: $0 VERSION rc"
+ echo " $0 VERSION staging-rc"
+ echo " $0 VERSION release"
+ echo " $0 VERSION staging-release"
+ echo " $0 VERSION local"
+ echo " e.g.: $0 0.13.0 3 # Verify 0.13.0 3"
+ echo " e.g.: $0 0.13.0 staging-rc # Verify 0.13.0 RC on staging"
+ echo " e.g.: $0 0.13.0 release # Verify 0.13.0"
+ echo " e.g.: $0 0.13.0 staging-release # Verify 0.13.0 on staging"
+ echo " e.g.: $0 0.13.0-dev20210203 local # Verify 0.13.0-dev20210203 on
local"
+ exit 1
+fi
+
+VERSION="$1"
+TYPE="$2"
+
+sudo dnf -y update
+sudo dnf clean all
+sudo dnf -y install dnf-plugins-core
+sudo dnf config-manager --set-enabled powertools
+sudo dnf update
+sudo dnf -y install \
+ https://dl.fedoraproject.org/pub/epel/epel-release-latest-8.noarch.rpm
+sudo dnf -y install ninja-build libcurl-devel python3-pip cmake git
+sudo dnf -y ncurses-devel gobject-introspection-devel libffi-devel
+sudo dnf -y install openssl-devel maven java-1.8.0-openjdk-devel
+sudo dnf install -y yum-utils readline-devel gdbm-devel ruby-devel
Review comment:
Could you unify to one `dnf install`?
```bash
sudo dnf -y install \
... \
...
```
##########
File path: dev/release/setup-AlmaLinux-Rocky-Linux.sh
##########
@@ -0,0 +1,56 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+# A script to install dependencies required for release
+# verification on AlmaLinux 8 and Rocky Linux 8
+
+if [ $# -lt 2 ]; then
+ echo "Usage: $0 VERSION rc"
+ echo " $0 VERSION staging-rc"
+ echo " $0 VERSION release"
+ echo " $0 VERSION staging-release"
+ echo " $0 VERSION local"
+ echo " e.g.: $0 0.13.0 3 # Verify 0.13.0 3"
+ echo " e.g.: $0 0.13.0 staging-rc # Verify 0.13.0 RC on staging"
+ echo " e.g.: $0 0.13.0 release # Verify 0.13.0"
+ echo " e.g.: $0 0.13.0 staging-release # Verify 0.13.0 on staging"
+ echo " e.g.: $0 0.13.0-dev20210203 local # Verify 0.13.0-dev20210203 on
local"
+ exit 1
+fi
+
+VERSION="$1"
+TYPE="$2"
+
+sudo dnf -y update
+sudo dnf clean all
+sudo dnf -y install dnf-plugins-core
+sudo dnf config-manager --set-enabled powertools
+sudo dnf update
+sudo dnf -y install \
+ https://dl.fedoraproject.org/pub/epel/epel-release-latest-8.noarch.rpm
+sudo dnf -y install ninja-build libcurl-devel python3-pip cmake git
+sudo dnf -y ncurses-devel gobject-introspection-devel libffi-devel
+sudo dnf -y install openssl-devel maven java-1.8.0-openjdk-devel
+sudo dnf install -y yum-utils readline-devel gdbm-devel ruby-devel
+sudo dnf -y groupinstall "Development Tools"
+sudo dnf -y module enable llvm-toolset
+sudo dnf -y module install llvm-toolset
+sudo dnf -y install llvm-devel
+git clone https://github.com/apache/arrow
+cd arrow/
+dev/release/verify-release-candidate.sh source $VERSION $TYPE
Review comment:
How about running `dev/release/verify-release-candidate.sh` separately
instead of running from this script?
`setup-XXX.sh` script should just setup. And users who run this script must
have cloned `apache/arrow` directory.
##########
File path: dev/release/VERIFY.md
##########
@@ -74,3 +74,26 @@ You need to set `PKG_CONFIG_PATH` to find libffi on macOS:
```console
% export PKG_CONFIG_PATH=$(brew --prefix libffi)/lib/pkgconfig:$PKG_CONFIG_PATH
```
+
+### C++, C#, C GLib, Go, JavaScript, Python, Ruby
+
+Example scripts to install the dependencies to run the verification
+script for verifying the source on Ubuntu 20.04, Rocky Linux 8 and
+AlmaLinux 8 are in this folder and named `setup-Ubuntu.sh` and
+`setup-AlmaLinux-Rocky-Linux.sh`. These can be adapted to different
Review comment:
Could you use lowercase for file name?
##########
File path: dev/release/setup-AlmaLinux-Rocky-Linux.sh
##########
@@ -0,0 +1,56 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+# A script to install dependencies required for release
+# verification on AlmaLinux 8 and Rocky Linux 8
+
+if [ $# -lt 2 ]; then
+ echo "Usage: $0 VERSION rc"
+ echo " $0 VERSION staging-rc"
+ echo " $0 VERSION release"
+ echo " $0 VERSION staging-release"
+ echo " $0 VERSION local"
+ echo " e.g.: $0 0.13.0 3 # Verify 0.13.0 3"
+ echo " e.g.: $0 0.13.0 staging-rc # Verify 0.13.0 RC on staging"
+ echo " e.g.: $0 0.13.0 release # Verify 0.13.0"
+ echo " e.g.: $0 0.13.0 staging-release # Verify 0.13.0 on staging"
+ echo " e.g.: $0 0.13.0-dev20210203 local # Verify 0.13.0-dev20210203 on
local"
+ exit 1
+fi
+
+VERSION="$1"
+TYPE="$2"
+
+sudo dnf -y update
+sudo dnf clean all
+sudo dnf -y install dnf-plugins-core
Review comment:
Are they needed?
##########
File path: dev/release/setup-AlmaLinux-Rocky-Linux.sh
##########
@@ -0,0 +1,56 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+# A script to install dependencies required for release
+# verification on AlmaLinux 8 and Rocky Linux 8
Review comment:
How about renaming to `setup-rhel.sh` and use `RHEL clones such as ...`?
##########
File path: dev/release/setup-AlmaLinux-Rocky-Linux.sh
##########
@@ -0,0 +1,56 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+# A script to install dependencies required for release
+# verification on AlmaLinux 8 and Rocky Linux 8
+
+if [ $# -lt 2 ]; then
+ echo "Usage: $0 VERSION rc"
+ echo " $0 VERSION staging-rc"
+ echo " $0 VERSION release"
+ echo " $0 VERSION staging-release"
+ echo " $0 VERSION local"
+ echo " e.g.: $0 0.13.0 3 # Verify 0.13.0 3"
+ echo " e.g.: $0 0.13.0 staging-rc # Verify 0.13.0 RC on staging"
+ echo " e.g.: $0 0.13.0 release # Verify 0.13.0"
+ echo " e.g.: $0 0.13.0 staging-release # Verify 0.13.0 on staging"
+ echo " e.g.: $0 0.13.0-dev20210203 local # Verify 0.13.0-dev20210203 on
local"
+ exit 1
+fi
+
+VERSION="$1"
+TYPE="$2"
+
+sudo dnf -y update
+sudo dnf clean all
+sudo dnf -y install dnf-plugins-core
+sudo dnf config-manager --set-enabled powertools
+sudo dnf update
Review comment:
`-y` is missing?
##########
File path: dev/tasks/verify-rc-alma/Dockerfile
##########
@@ -0,0 +1,8 @@
+# Container image that runs
+FROM almalinux:8.4
+
+# Copy script into container
+COPY setup-AlmaLinux-Rocky-Linux.sh /setup-AlmaLinux-Rocky-Linux.sh
+
+# Execute script
+ENTRYPOINT ["/setup-AlmaLinux-Rocky-Linux.sh"]
Review comment:
We don't need this file.
We can use `--volume` for using file on host.
##########
File path: dev/release/setup-AlmaLinux-Rocky-Linux.sh
##########
@@ -0,0 +1,56 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+# A script to install dependencies required for release
+# verification on AlmaLinux 8 and Rocky Linux 8
+
+if [ $# -lt 2 ]; then
+ echo "Usage: $0 VERSION rc"
+ echo " $0 VERSION staging-rc"
+ echo " $0 VERSION release"
+ echo " $0 VERSION staging-release"
+ echo " $0 VERSION local"
+ echo " e.g.: $0 0.13.0 3 # Verify 0.13.0 3"
+ echo " e.g.: $0 0.13.0 staging-rc # Verify 0.13.0 RC on staging"
+ echo " e.g.: $0 0.13.0 release # Verify 0.13.0"
+ echo " e.g.: $0 0.13.0 staging-release # Verify 0.13.0 on staging"
+ echo " e.g.: $0 0.13.0-dev20210203 local # Verify 0.13.0-dev20210203 on
local"
+ exit 1
+fi
+
+VERSION="$1"
+TYPE="$2"
+
+sudo dnf -y update
+sudo dnf clean all
+sudo dnf -y install dnf-plugins-core
+sudo dnf config-manager --set-enabled powertools
+sudo dnf update
+sudo dnf -y install \
+ https://dl.fedoraproject.org/pub/epel/epel-release-latest-8.noarch.rpm
Review comment:
Can we use `sudo dnf -y install epel-release`?
##########
File path: dev/tasks/verify-rc-alma/setup-AlmaLinux-Rocky-Linux.sh
##########
@@ -0,0 +1,59 @@
+#!/bin/sh -l
Review comment:
We should not have duplicated file in this repository.
We should use `dev/release/setup-...`.
##########
File path: dev/tasks/verify-rc-alma/action.yml
##########
@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
We don't need to create a new directory for this. We can reuse
`/dev/tasks/verify-rc/` directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
