westonpace commented on a change in pull request #11556:
URL: https://github.com/apache/arrow/pull/11556#discussion_r741556138
##########
File path: cpp/src/arrow/util/async_util.h
##########
@@ -176,6 +176,13 @@ class ARROW_EXPORT SerializedAsyncTaskGroup {
/// The returned future that will finish when all tasks have been consumed.
Future<> End();
+ /// Abort a task group
+ ///
+ /// Tasks that have not been started will be discarded
+ ///
+ /// The returned future will finish when all running tasks have finished.
+ Future<> Abort(Status err);
Review comment:
Although now that I took abort out of the dataset writer this isn't
used. But, it will come back in later so I'd like to just leave it.
##########
File path: cpp/src/arrow/dataset/dataset_writer_test.cc
##########
@@ -145,8 +160,10 @@ class DatasetWriterTestFixture : public testing::Test {
for (const auto& expected_file : expected_files) {
util::optional<MockFileInfo> written_file =
FindFile(expected_file.filename);
AssertFileCreated(written_file, expected_file.filename);
+ int num_batches;
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
