jonkeane commented on a change in pull request #11575:
URL: https://github.com/apache/arrow/pull/11575#discussion_r742151481
##########
File path: r/tests/testthat/test-dplyr-funcs-datetime.R
##########
@@ -80,6 +80,25 @@ test_that("extract month from timestamp", {
collect(),
test_df
)
+
+ skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168
+
+ compare_dplyr_binding(
+ .input %>%
+ # R returns ordered factor whereas Arrow returns character
+ mutate(x = as.character(month(datetime, label = TRUE))) %>%
+ collect(),
+ test_df,
+ ignore_attr = TRUE
+ )
+
+ compare_dplyr_binding(
+ .input %>%
+ mutate(x = as.character(month(datetime, label = TRUE, abbr = TRUE))) %>%
+ collect(),
+ test_df,
+ ignore_attr = TRUE
+ )
Review comment:
Would it be useful/helpful/important to test a date column too?
##########
File path: r/tests/testthat/test-dplyr-funcs-datetime.R
##########
@@ -80,6 +80,25 @@ test_that("extract month from timestamp", {
collect(),
test_df
)
+
+ skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168
+
+ compare_dplyr_binding(
+ .input %>%
+ # R returns ordered factor whereas Arrow returns character
Review comment:
I wonder if this is a fact we should warn about?
##########
File path: r/tests/testthat/test-dplyr-funcs-datetime.R
##########
@@ -80,6 +80,25 @@ test_that("extract month from timestamp", {
collect(),
test_df
)
+
+ skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168
+
+ compare_dplyr_binding(
+ .input %>%
+ # R returns ordered factor whereas Arrow returns character
Review comment:
Docs only is probably just fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
