jonkeane commented on pull request #11534: URL: https://github.com/apache/arrow/pull/11534#issuecomment-961271239
I share some of Neals concerns about readability, but overall I think this pattern will help us more than it will hurt us going forward. The [improvement suggested of adding a helper](https://github.com/apache/arrow/pull/11534#discussion_r735734467) that wraps some of the extra parens, etc. will address some of that (could we add that in on this PR and see how it looks?) We should also see what others think about this pattern and if we want to start using it more broadly (and slowly move our current tests over, but I think we can do that as we interact with them and don't need to dedicate time to moving everything over all at once). We could ➕ / ➖ on this comment to indicate which way we want to go -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
