lichuan6 edited a comment on pull request #1237:
URL: https://github.com/apache/arrow-datafusion/pull/1237#issuecomment-961631017
> @lichuan6 there appears to be some failures on the CI checks
OK, thanks @alamb for pointing it out. It seems using
`self.consume_token(&Token::make_keyword("WITH"))` will only recognize upper
case keyword. What's the best way to do case-insensitive token parsing?
Currently, after changing signature from
```rust
fn consume_token(&mut self, expected: &str) -> bool
```
to
```rust
fn consume_token(&mut self, expected: &Token) -> bool
```
to do case-insensitive parsing, I created a new `Token::Word` enum with
upper case of next token. Don't know if this is the best practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
