emkornfield commented on pull request #11359: URL: https://github.com/apache/arrow/pull/11359#issuecomment-962306139
> I've addressed the comments you left either via comments or via changes. I tend to lend more towards being less unfriendly wherever possible rather than letting it fail personally which is why I took the tact I did in a lot of the places, but I also see the value in matching behavior of the C++ It's not so much about matching C++, as it is about users getting unexpected results. I don't know if there is a good way to disclose some of caveats in a way a user will actually look at before blindly going ahead and using the library. For now clear documentation for both reading and writing that data is attempted to be coerced as best as possible to the schema provided and might lose some data from the original JSON is fine. We can re-assess if anyone opens up bugs because of this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
