xudong963 commented on a change in pull request #1135:
URL: https://github.com/apache/arrow-datafusion/pull/1135#discussion_r744109782



##########
File path: datafusion/src/physical_plan/hash_join.rs
##########
@@ -120,6 +120,8 @@ pub struct HashJoinExec {
     metrics: ExecutionPlanMetricsSet,
     /// Information of index and left / right placement of columns
     column_indices: Vec<ColumnIndex>,
+    /// If null_equal_null is true, null == null else null != null

Review comment:
       I agree, we should keep preciseness! 👍🏻




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to