jorisvandenbossche commented on a change in pull request #11632:
URL: https://github.com/apache/arrow/pull/11632#discussion_r744116947
##########
File path: python/pyarrow/dataset.py
##########
@@ -798,6 +799,18 @@ def write_dataset(data, base_dir, basename_template=None,
format=None,
def file_visitor(written_file):
visited_paths.append(written_file.path)
+ existing_data_behavior : 'error' | 'overwrite' | 'delete_matching'
Review comment:
I know "overwrite_or_ignore" would get long, but on the other hand it is
also more explicit .. One could misinterpret "overwrite" as "overwrite the full
dataset" instead of "overwrite matching files and ignore the others" (one for
me "overwrite the full dataset" would mean it deletes all files, whether they
would clash or not)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
