thisisnic commented on a change in pull request #11534:
URL: https://github.com/apache/arrow/pull/11534#discussion_r745398724
##########
File path: r/tests/testthat/helper-expectation.R
##########
@@ -317,3 +317,7 @@ split_vector_as_list <- function(vec) {
vec2 <- vec[seq(from = min(length(vec), vec_split + 1), to = length(vec), by
= 1)]
list(vec1, vec2)
}
+
+err_helper <- function(...) (expect_error(...))
Review comment:
More verbose, but how about `expect_error_snapshot()` and
`expect_warning_snapshot()`? Or without the `expect` if that makes more sense
(I haven't read this bit of code in-depth yet). I'm in favour of leaving full
words as-is if it's not causing conflicts or overly long names, as it makes
easier to guess what's happening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
