[GitHub] [arrow] dragosmg commented on pull request #11534: ARROW-14458 [R] Use expect_snapshot() to improve tests in dplyr funcs strings

[GitBox]

dragosmg commented on pull request #11534:
URL: https://github.com/apache/arrow/pull/11534#issuecomment-964014256


   This is what the C++ surfaced error looks like after switching to 
`expect_snapshot()` for the test on row 835.
   test:
   <img width="995" alt="image" 
src="https://user-images.githubusercontent.com/13176361/140906815-12b84035-b4f3-43e3-a70e-4133566016d7.png";>
   snapshot:
   <img width="997" alt="image" 
src="https://user-images.githubusercontent.com/13176361/140906862-babd2b3c-fd89-44c2-8cb9-4e4e48e742ea.png";>
   As far as I can tell the snapshot includes some sort of C++ traceback but 
with paths referencing stuff on my machine. We were making use of the `regexp` 
argument of `expect_error()` for partial matching of error messages in the 
original test:
   ```
     expect_error(
       times %>%
         Table$create() %>%
         mutate(x = strftime(datetime, format = "%c")) %>%
         collect(),
       "%c flag is not supported in non-C locales."
     )
   ``` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org