pitrou commented on a change in pull request #11505:
URL: https://github.com/apache/arrow/pull/11505#discussion_r745481657
##########
File path: docs/source/developers/python.rst
##########
@@ -335,6 +335,11 @@ virtualenv) enables cmake to choose the python executable
which you are using.
For any other C++ build challenges, see :ref:`cpp-development`.
+In case you may need to rebuild the C++ part due to errors in the process it is
+advisable to delete the content of the build folder with command ``rm -rf *``
+from the build folder itself. If the build has passed successfully and you
need to rebuild
Review comment:
It's generally puzzling for people if you offer two different ways of
doing the same thing. Also, here, it won't be doing exactly the same thing,
which can be even more confusing. I would generally advocate `git clean -Xfd`
because it should clean all build leftovers, including ones that may be outside
of the build directory (it shouldn't happen in C++, but it can happen in
Python).
##########
File path: docs/source/developers/python.rst
##########
@@ -55,12 +55,15 @@ like so:
.. code-block:: shell
- pytest pyarrow
+ pytest arrow/python/pyarrow
Review comment:
Hmm, I don't know, I never move back to the parent directory. Usually I
would have one or several shells opened in the `cpp` directory and another one
in the `python` directory, so I avoid back-and-forths.
So, yes, I would vote for staying in the `python` directory after building
PyArrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
