lidavidm commented on a change in pull request #11368:
URL: https://github.com/apache/arrow/pull/11368#discussion_r745871342
##########
File path: python/pyarrow/tests/parquet/test_dataset.py
##########
@@ -449,7 +449,7 @@ def test_filters_inclusive_set(tempdir, use_legacy_dataset):
dataset = pq.ParquetDataset(
base_path, filesystem=fs,
filters=[('integer', 'in', [1]), ('string', 'in', ('a', 'b')),
- ('boolean', 'not in', {False})],
+ ('boolean', 'not in', {'False'})],
Review comment:
Before it got implicitly cast to string and compared that way, now the
check added disallows that (hence the behavior difference). I think it's
because we don't infer boolean partition values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
